Fix IHttpContextAccessor warning

[304NotModified]

fixes #157

[codecov]

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   58.18%   58.18%           
=======================================
  Files          29       29           
  Lines         385      385           
  Branches       93       93           
=======================================
  Hits          224      224           
  Misses        125      125           
  Partials       36       36

Impacted Files	Coverage Δ
...etCore/LayoutRenderers/AspNetLayoutRendererBase.cs	87.5% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc7c576...2337305. Read the comment docs.

[codecov]

Codecov Report

Merging #180 into master will decrease coverage by 0.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   58.18%   57.66%   -0.52%     
==========================================
  Files          29       29              
  Lines         385      385              
  Branches       93       93              
==========================================
- Hits          224      222       -2     
  Misses        125      125              
- Partials       36       38       +2

Impacted Files	Coverage Δ
...etCore/LayoutRenderers/AspNetLayoutRendererBase.cs	87.5% <ø> (ø)	⬆️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs	80.76% <0%> (-3.85%)	⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs	95.12% <0%> (-2.44%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc7c576...2337305. Read the comment docs.

[snakefoot]

@304NotModified Could be nice if AspNetLayoutRendererBase.Initialize() generated a warning, when HttpContextAccessor is null (And not a debug message for every property-access). As the initial proposal suggested #133 (but changed after some refactoring).

[304NotModified]

@304NotModified Could be nice if AspNetLayoutRendererBase.Initialize() generated a warning, when HttpContextAccessor is null (

That was the case and we got multiple tickets for the warning. So now debug and only on usage.

[snakefoot]

Did you notice comments like these:

All logging fields like aspnet-* are not included in logs.

Which actually means the logging is not working, because it has been initialized wrong. Maybe the NLog Example should be fixed to perform proper initialization so the layout-renderer works.

But anyway just curious, why it has been removed, besides noise from people finding NLog hard to use in ASP.NET (Maybe fix the issue with it being hard to use)

[304NotModified]

The new way (working on it), is less difficult to setup :)

[Surge001]

Can't wait on the new way to be released. Please let us know in this trail when released!
thnx!

[304NotModified]

Yes I will! Hopefully this weekend!