Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASP.NET Core 2.1, UseNLog on IHostBuilder, ${configsetting} uses UseNLog, Logging:NLog section #335

Merged
merged 1 commit into from
Jan 25, 2019
Merged

ASP.NET Core 2.1, UseNLog on IHostBuilder, ${configsetting} uses UseNLog, Logging:NLog section #335

merged 1 commit into from
Jan 25, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jan 16, 2019 •
edited by 304NotModified
Loading

  • Updated to ASP.NET Core 2.1 that has Long-Term-Support (LTS)
  • ${configsetting} layout renderer now depends on UseNLog-call to provide IConfiguration using IServiceProvider
  • NLogLoggerProvider options now binds to IConfiguration (Using section Logging:NLog)
  • UseNLog-call now also available for IHostBuilder

@snakefoot snakefoot force-pushed the master branch 2 times, most recently from 1cf3843 to 7b82c4f Compare January 17, 2019 00:12
@codecov
Copy link

codecov bot commented Jan 17, 2019 •
edited
Loading

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #335   +/-   ##
=====================================
  Coverage      63%    63%           
=====================================
  Files          34     34           
  Lines         468    468           
  Branches      103    103           
=====================================
  Hits          296    296           
  Misses        134    134           
  Partials       38     38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdf815...a34761f. Read the comment docs.

@snakefoot snakefoot force-pushed the master branch 3 times, most recently from 3a8a5f0 to 73588c5 Compare January 17, 2019 06:42
@304NotModified 304NotModified self-assigned this Jan 17, 2019
304NotModified
304NotModified reviewed Jan 17, 2019
View reviewed changes
appveyor.yml Outdated
@@ -7,8 +7,8 @@ assembly_info:
patch: true
file: '**\AssemblyInfo.cs'
assembly_version: '4.0.0'
assembly_file_version: '4.7.1.{build}' #NLog.Web
assembly_informational_version: '4.7.1' #NLog.Web
assembly_file_version: '4.8.0.{build}' #NLog.Web
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.8 because the update of the dependency? So skip 4.7.2?

Copy link
Contributor Author

@snakefoot snakefoot Jan 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking the dependency update for NLog.Web.AspNetCore was "huge" change :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I keep NLog.Web at 4.7.1 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted version change for NLog.Web

NLog.Web.AspNetCore/NLog.Web.AspNetCore.csproj Show resolved Hide resolved
@304NotModified 304NotModified added this to the 4.8 milestone Jan 25, 2019
@304NotModified 304NotModified merged commit 6335740 into NLog:master Jan 25, 2019
@304NotModified
Copy link
Member

Thanks!

@304NotModified 304NotModified changed the title Register WebHost configuration with ${configsetting} and LoggingProvider-options ASP.NET Core 2.1, UseNLog on IHostBuilder, ${configsetting} uses UseNLog, Logging:NLog section Jan 30, 2019
@snakefoot snakefoot mentioned this pull request Aug 15, 2019
Closed
@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 1 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified left review comments

Assignees

@304NotModified 304NotModified

Labels
ASP.NET Core ASP.NET Core - all versions
Projects
None yet
Milestone
NLog.Web + NLog.Web.AspNetCore 4.8
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @304NotModified