Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ${aspnet-request-posted-body} #339

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Conversation

304NotModified
Copy link
Member

fixes #103

@codecov
Copy link

codecov bot commented Feb 10, 2019

Codecov Report

Merging #339 into master will decrease coverage by 2%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #339   +/-   ##
=====================================
- Coverage      63%    61%   -2%     
=====================================
  Files          34     35    +1     
  Lines         468    485   +17     
  Branches      103    111    +8     
=====================================
  Hits          296    296           
- Misses        134    151   +17     
  Partials       38     38
Impacted Files Coverage Δ
...etCore/LayoutRenderers/AspNetRequestPostedValue.cs 0% <0%> (ø)
...enderers/AspNetRequestQueryStringLayoutRenderer.cs 82% <0%> (-5%) ⬇️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 88% <0%> (-4%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 88% <0%> (-1%) ⬇️
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs 97% <0%> (+8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e3571...414864a. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 10, 2019

Codecov Report

Merging #339 into master will increase coverage by 1%.
The diff coverage is 76%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #339   +/-   ##
=====================================
+ Coverage      63%    64%   +1%     
=====================================
  Files          34     36    +2     
  Lines         468    492   +24     
  Branches      103    112    +9     
=====================================
+ Hits          296    314   +18     
- Misses        134    136    +2     
- Partials       38     42    +4
Impacted Files Coverage Δ
...NetCore/LayoutRenderers/AspNetRequestPostedBody.cs 76% <76%> (ø)
...enderers/AspNetRequestQueryStringLayoutRenderer.cs 82% <0%> (-5%) ⬇️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 88% <0%> (-4%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 88% <0%> (-1%) ⬇️
...pNetCore/LayoutRenderers/AspNetRequestUserAgent.cs 71% <0%> (ø)
...ayoutRenderers/AspNetRequestValueLayoutRenderer.cs 97% <0%> (+8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e3571...be92a37. Read the comment docs.

@304NotModified 304NotModified changed the title Addded ${aspnet-request-posted-value} Addded ${aspnet-request-posted-body} Feb 11, 2019
@304NotModified 304NotModified merged commit 665c62e into master Feb 11, 2019
@304NotModified 304NotModified deleted the aspnet-postedvalue branch February 11, 2019 22:46
@snakefoot
Copy link
Contributor

#754 has reverted this in NLog.Web ver. 5.0

@snakefoot snakefoot changed the title Addded ${aspnet-request-posted-body} Added ${aspnet-request-posted-body} Feb 12, 2022
@snakefoot
Copy link
Contributor

Thanks to @bakgerman now NLog.Web.AspNetCore v5.1 re-introduces ${aspnet-request-posted-body} with help from middleware:

app.UseMiddleware<NLog.Web.NLogRequestPostedBodyMiddleware>();

It is no longer necessary to explicit call context.Request.EnableBuffering(); as it is handled by the middleware.

@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions docs docs done and removed ASP.NET Core 1 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET Core ASP.NET Core - all versions ASP.NET 4 ASP.NET MVC Classic docs done docs feature size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ${aspnet-request-posted-body} - log posted request body/payload
2 participants