Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppVeyor build for NLog.Web on master branch #405

Merged
merged 1 commit into from
May 5, 2019

Conversation

snakefoot
Copy link
Contributor

VersionSuffix should also apply for NLog.Web-build

@codecov-io
Copy link

codecov-io commented May 5, 2019

Codecov Report

Merging #405 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #405   +/-   ##
=====================================
  Coverage      62%    62%           
=====================================
  Files          35     35           
  Lines         528    528           
  Branches      122    122           
=====================================
  Hits          328    328           
  Misses        162    162           
  Partials       38     38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845a990...9e0c15f. Read the comment docs.

@snakefoot
Copy link
Contributor Author

snakefoot commented May 5, 2019

@304NotModified
Copy link
Member

THanks!

Not sure if https://www.nuget.org/packages/NLog.Web/4.8.2 should be unlisted?

We don't broke anything, so it's not really a problem. Leave it like that, as we can't create another 4.8.2 after all.

@304NotModified 304NotModified merged commit ea1af37 into NLog:master May 5, 2019
@snakefoot
Copy link
Contributor Author

But it looks like the PR worked. Now we also have:

https://www.nuget.org/packages/NLog.Web/4.8.2-rc1

But strange symbols has not been broken for:

https://www.nuget.org/packages/NLog.Web.AspNetCore/4.8.2-rc1

@304NotModified
Copy link
Member

They only break if there are code changes with the same version ;)

@304NotModified
Copy link
Member

But it looks like the PR worked. Now we also have:

https://www.nuget.org/packages/NLog.Web/4.8.2-rc1

I think I will release the RTM for ASPnetcore soon, so we can focus on other stuff :)

@snakefoot
Copy link
Contributor Author

@304NotModified Thought you wanted to give the ${AspNetRequestPostedBody} some more attention with splitting MaxContentLength into more parameters and adding ContentType-filter

@304NotModified
Copy link
Member

Yes, but I try to keep the aspnet4 and aspnetcore a bit in sync, so therefor releasing 4.8.2 now and we always add those features to another version

@304NotModified
Copy link
Member

I think it at least a very good improvement now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants