-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AppVeyor build for NLog.Web on master branch #405
Conversation
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
=====================================
Coverage 62% 62%
=====================================
Files 35 35
Lines 528 528
Branches 122 122
=====================================
Hits 328 328
Misses 162 162
Partials 38 38 Continue to review full report at Codecov.
|
Not sure if https://www.nuget.org/packages/NLog.Web/4.8.2 should be unlisted? But https://www.nuget.org/packages/NLog.Web.AspNetCore/4.8.2-rc1 looks good :) |
THanks!
We don't broke anything, so it's not really a problem. Leave it like that, as we can't create another 4.8.2 after all. |
But it looks like the PR worked. Now we also have: https://www.nuget.org/packages/NLog.Web/4.8.2-rc1 But strange symbols has not been broken for: https://www.nuget.org/packages/NLog.Web.AspNetCore/4.8.2-rc1 |
They only break if there are code changes with the same version ;) |
I think I will release the RTM for ASPnetcore soon, so we can focus on other stuff :) |
@304NotModified Thought you wanted to give the |
Yes, but I try to keep the aspnet4 and aspnetcore a bit in sync, so therefor releasing 4.8.2 now and we always add those features to another version |
I think it at least a very good improvement now :) |
VersionSuffix should also apply for NLog.Web-build