Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better checking for availability of session #436

Merged
merged 3 commits into from
Jun 17, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jun 13, 2019

See also #435

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #436 into master will increase coverage by <1%.
The diff coverage is 71%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #436    +/-   ##
======================================
+ Coverage      62%    62%   +<1%     
======================================
  Files          35     35            
  Lines         527    533     +6     
  Branches      123    127     +4     
======================================
+ Hits          327    332     +5     
- Misses        158    160     +2     
+ Partials       42     41     -1
Impacted Files Coverage Δ
...d/LayoutRenderers/AspNetSessionIdLayoutRenderer.cs 100% <100%> (+17%) ⬆️
src/Shared/Internal/HttpContextExtensions.cs 64% <64%> (ø)
...ayoutRenderers/AspNetSessionValueLayoutRenderer.cs 88% <67%> (+6%) ⬆️
...Shared/LayoutRenderers/AspNetLayoutRendererBase.cs 60% <0%> (-20%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 90% <0%> (+1%) ⬆️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 92% <0%> (+4%) ⬆️
...enderers/AspNetRequestQueryStringLayoutRenderer.cs 86% <0%> (+5%) ⬆️
...d/LayoutRenderers/AspNetItemValueLayoutRenderer.cs 93% <0%> (+7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a51f5...2d10dd4. Read the comment docs.

@304NotModified
Copy link
Member

Thanks for splitting! I only needed to review 42e61f6, it wasn't a Size/L then :)

@304NotModified 304NotModified changed the title aspnet-session - Reduce log-level to debug when session is not available Better checking for availability of session Jun 16, 2019
@snakefoot
Copy link
Contributor Author

Tried to merge #440 into this.

@304NotModified
Copy link
Member

Thanks! So this one supersedes #440? Maybe nice to change the author of the (last?) commit? 👼

@snakefoot
Copy link
Contributor Author

snakefoot commented Jun 17, 2019 via email

@304NotModified
Copy link
Member

I meant, amend and change author. e.g.

git commit --amend --author="Author Name <email@address.com>"

@snakefoot
Copy link
Contributor Author

Commit amend performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants