Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ASP.NET Core 3 #496

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Support ASP.NET Core 3 #496

merged 1 commit into from
Oct 11, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 7, 2019 •
edited
Loading

Updated dependencies:

  <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.0' ">
    <FrameworkReference Include="Microsoft.AspNetCore.App" />
  </ItemGroup>

See also: https://docs.microsoft.com/en-us/aspnet/core/fundamentals/metapackage-app?view=aspnetcore-3.0

@snakefoot snakefoot mentioned this pull request Oct 8, 2019
Closed
6 tasks
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 8, 2019
@304NotModified 304NotModified changed the title TargetFramework netcoreapp3.0 Support ASP.NET Core 3 Oct 11, 2019
@304NotModified 304NotModified merged commit 089cf91 into NLog:dev Oct 11, 2019
@304NotModified
Copy link
Member

great work! Thanks! Also great work on the NSubstitute things 💯 👍

This was referenced Oct 11, 2019
Closed
Closed
@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 3 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ASP.NET Core ASP.NET Core - all versions feature size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @304NotModified