Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

${aspnet-traceidentifier} should automatically check Activity.Current.Id for ASP.NET Core 3 #524

Merged
merged 2 commits into from
Feb 24, 2020
Merged

${aspnet-traceidentifier} should automatically check Activity.Current.Id for ASP.NET Core 3 #524

merged 2 commits into from
Feb 24, 2020

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 23, 2020 •
edited
Loading

This is what's used in ASP .NET Core 3 templates showing Request Id. Should do the same for consistency.

Resolves #523

See also: https://github.com/dotnet/aspnetcore/blob/2e4274cb67c049055e321c18cc9e64562da52dcf/src/Mvc/Mvc.Core/src/Infrastructure/DefaultProblemDetailsFactory.cs#L90

@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 23, 2020
@304NotModified 304NotModified merged commit 7c6861d into NLog:dev Feb 24, 2020
@304NotModified 304NotModified changed the title aspnet-traceidentifier should automatically check Activity.Current.Id for AspNetCore3 ${aspnet-traceidentifier} should automatically check Activity.Current.Id for ASP.NET Core 3 Feb 24, 2020
@304NotModified 304NotModified added this to the 4.9.1 milestone Feb 24, 2020
@304NotModified
Copy link
Member

maybe 4.10 is better for this?

Unfortunately NLog.Web (so not aspnetcore), has no changes after 4.9 (im trying to keep them in sync)

snakefoot added a commit to snakefoot/NLog.Web that referenced this pull request Mar 25, 2020
@snakefoot
aspnet-traceidentifier should automatically check Activity.Current.Id…
2b1060b 
… for AspNetCore3 (NLog#524)

* aspnet-traceidentifier should automatically check System.Diagnostics.Activity.Current for AspNetCore3

* aspnet-traceidentifier should automatically check System.Diagnostics.Activity.Current for AspNetCore3 (test)
304NotModified added a commit that referenced this pull request Mar 30, 2020
@snakefoot @304NotModified @dependabot-preview
NLog.AspNetCore ver. 4.9.1 (#533)
18b41af 
* Update README.md

* remove broken badge

* Bump NLog from 4.6.7 to 4.6.8 in /src/NLog.Web

Bumps [NLog](https://github.com/NLog/NLog) from 4.6.7 to 4.6.8.
- [Release notes](https://github.com/NLog/NLog/releases)
- [Changelog](https://github.com/NLog/NLog/blob/v4.6.8/CHANGELOG.md)
- [Commits](NLog/NLog@v4.6.7...v4.6.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Code Cleanup to remove unused usings (Sonar Warnings)

* Bump Microsoft.NET.Test.Sdk in /tests/NLog.Web.Tests (#510)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.2.0 to 16.4.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.2.0...v16.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump Microsoft.NET.Test.Sdk in /tests/NLog.Web.AspNetCore.Tests (#509)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.2.0 to 16.4.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.2.0...v16.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump MSTest.TestAdapter from 2.0.0 to 2.1.0 in /tests/NLog.Web.Tests (#518)

Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/microsoft/testfx/releases)
- [Commits](microsoft/testfx@v2.0.0...v2.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump MSTest.TestFramework from 2.0.0 to 2.1.0 in /tests/NLog.Web.Tests (#517)

Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/microsoft/testfx/releases)
- [Commits](microsoft/testfx@v2.0.0...v2.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump Microsoft.NET.Test.Sdk in /tests/NLog.Web.AspNetCore.Tests (#520)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.4.0...v16.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump Microsoft.NET.Test.Sdk in /tests/NLog.Web.Tests (#521)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.4.0...v16.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* aspnet-traceidentifier should automatically check Activity.Current.Id for AspNetCore3 (#524)

* aspnet-traceidentifier should automatically check System.Diagnostics.Activity.Current for AspNetCore3

* aspnet-traceidentifier should automatically check System.Diagnostics.Activity.Current for AspNetCore3 (test)

* Bump NLog.Extensions.Logging in /tests/NLog.Web.AspNetCore.Tests (#525)

Bumps [NLog.Extensions.Logging](https://github.com/NLog/NLog.Extensions.Logging) from 1.6.1 to 1.6.2.
- [Release notes](https://github.com/NLog/NLog.Extensions.Logging/releases)
- [Changelog](https://github.com/NLog/NLog.Extensions.Logging/blob/master/CHANGELOG.MD)
- [Commits](NLog/NLog.Extensions.Logging@v1.6.1...v1.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Improve AddNLog with LoggingConfiguration to handle custom LogFactory

* Version 4.9.1 for aspnetcore

Co-authored-by: Julian Verdurmen <304NotModified@users.noreply.github.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
snakefoot added a commit to snakefoot/NLog.Web that referenced this pull request Mar 30, 2020
@snakefoot @304NotModified @dependabot-preview
NLog.AspNetCore ver. 4.9.1 (NLog#533)
af9ac46 
* Update README.md

* remove broken badge

* Bump NLog from 4.6.7 to 4.6.8 in /src/NLog.Web

Bumps [NLog](https://github.com/NLog/NLog) from 4.6.7 to 4.6.8.
- [Release notes](https://github.com/NLog/NLog/releases)
- [Changelog](https://github.com/NLog/NLog/blob/v4.6.8/CHANGELOG.md)
- [Commits](NLog/NLog@v4.6.7...v4.6.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Code Cleanup to remove unused usings (Sonar Warnings)

* Bump Microsoft.NET.Test.Sdk in /tests/NLog.Web.Tests (NLog#510)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.2.0 to 16.4.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.2.0...v16.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump Microsoft.NET.Test.Sdk in /tests/NLog.Web.AspNetCore.Tests (NLog#509)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.2.0 to 16.4.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.2.0...v16.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump MSTest.TestAdapter from 2.0.0 to 2.1.0 in /tests/NLog.Web.Tests (NLog#518)

Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/microsoft/testfx/releases)
- [Commits](microsoft/testfx@v2.0.0...v2.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump MSTest.TestFramework from 2.0.0 to 2.1.0 in /tests/NLog.Web.Tests (NLog#517)

Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/microsoft/testfx/releases)
- [Commits](microsoft/testfx@v2.0.0...v2.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump Microsoft.NET.Test.Sdk in /tests/NLog.Web.AspNetCore.Tests (NLog#520)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.4.0...v16.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump Microsoft.NET.Test.Sdk in /tests/NLog.Web.Tests (NLog#521)

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.4.0...v16.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* aspnet-traceidentifier should automatically check Activity.Current.Id for AspNetCore3 (NLog#524)

* aspnet-traceidentifier should automatically check System.Diagnostics.Activity.Current for AspNetCore3

* aspnet-traceidentifier should automatically check System.Diagnostics.Activity.Current for AspNetCore3 (test)

* Bump NLog.Extensions.Logging in /tests/NLog.Web.AspNetCore.Tests (NLog#525)

Bumps [NLog.Extensions.Logging](https://github.com/NLog/NLog.Extensions.Logging) from 1.6.1 to 1.6.2.
- [Release notes](https://github.com/NLog/NLog.Extensions.Logging/releases)
- [Changelog](https://github.com/NLog/NLog.Extensions.Logging/blob/master/CHANGELOG.MD)
- [Commits](NLog/NLog.Extensions.Logging@v1.6.1...v1.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Improve AddNLog with LoggingConfiguration to handle custom LogFactory

* Version 4.9.1 for aspnetcore

Co-authored-by: Julian Verdurmen <304NotModified@users.noreply.github.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 3 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified left review comments

Assignees
No one assigned
Labels
ASP.NET Core ASP.NET Core - all versions enhancement size/M
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

Wrong trace identifier on ASP.Net Core 3.0
2 participants
@snakefoot @304NotModified