Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0 preview 2 #708

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Release 5.0 preview 2 #708

merged 3 commits into from
Oct 28, 2021

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Oct 28, 2021

Should fix

C:\Program Files\dotnet\sdk\5.0.401\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "NLog [5.0.0-preview.2, )" or update the version field in the nuspec. [C:\projects\nlogweb\src\NLog.Web\NLog.Web.csproj]
Command exited with code 1

See https://ci.appveyor.com/project/nlog/nlog-web/builds/41326999

@304NotModified
Copy link
Member Author

image

@304NotModified 304NotModified changed the title 5.0 preview 2 Release 5.0 preview 2 Oct 28, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@304NotModified 304NotModified merged commit 970eb19 into master Oct 28, 2021
@304NotModified 304NotModified deleted the 5.0-preview-2 branch October 28, 2021 19:45
@304NotModified 304NotModified added this to the 5.0 milestone Oct 28, 2021
@snakefoot
Copy link
Contributor

snakefoot commented Oct 28, 2021

Why merge Version5-preview2 when there is a preview3 ready? (Have only stalled merges/releases because build-pipeline has been broken)

Especially since NLog.Extensions.Logging 5.0 preview3 changes CaptureEntireEventId to CapureEventId

And it has become a published nuget-package with no proper description.

@304NotModified
Copy link
Member Author

because it depends of NLog preview2.

But I have no problem to delist this version if you think it's wrong

@snakefoot
Copy link
Contributor

Please de-list if possible. I prefer to make a "latest" NLog 5.0 release, when things are ready.

@304NotModified
Copy link
Member Author

Please de-list if possible.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants