Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AspNetRequestIsWebSocketLayoutRenderer - Changed from true / false to 1 / 0 #786

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

snakefoot
Copy link
Contributor

Followup to #784

@codecov-commenter
Copy link

Codecov Report

Merging #786 (9307375) into master (6bb5747) will increase coverage by 1%.
The diff coverage is 73%.

@@          Coverage Diff           @@
##           master   #786    +/-   ##
======================================
+ Coverage      66%    67%    +1%     
======================================
  Files          48     58    +10     
  Lines         797    949   +152     
  Branches      197    235    +38     
======================================
+ Hits          524    632   +108     
- Misses        196    223    +27     
- Partials       77     94    +17     
Impacted Files Coverage Δ
...rs/AspNetRequestClientCertificateLayoutRenderer.cs 50% <50%> (ø)
src/NLog.Web/NLogRequestPostedBodyModule.cs 60% <60%> (ø)
...outRenderers/AspNetRequestLocalIpLayoutRenderer.cs 67% <67%> (ø)
...tRenderers/AspNetRequestLocalPortLayoutRenderer.cs 67% <67%> (ø)
...Renderers/AspNetRequestRemotePortLayoutRenderer.cs 67% <67%> (ø)
...nderers/AspNetResponseContentTypeLayoutRenderer.cs 71% <71%> (ø)
...equestWebSocketRequestedProtocolsLayoutRenderer.cs 78% <78%> (ø)
...utRenderers/AspNetResponseHeadersLayoutRenderer.cs 78% <78%> (ø)
...Renderers/AspNetRequestPostedBodyLayoutRenderer.cs 85% <85%> (ø)
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 87% <92%> (+2%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a06ef8...9307375. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit a234cfc into NLog:master Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants