NLogRequestPostedBodyMiddleware - Only accept AllowContentTypes #787

snakefoot · 2022-06-04T13:06:43Z

No description provided.

codecov-commenter · 2022-06-04T13:13:41Z

Codecov Report

Merging #787 (2c5c87a) into master (a234cfc) will decrease coverage by 0%.
The diff coverage is 77%.

@@          Coverage Diff          @@
##           master   #787   +/-   ##
=====================================
- Coverage      67%    67%   -0%     
=====================================
  Files          58     58           
  Lines         949    976   +27     
  Branches      235    243    +8     
=====================================
+ Hits          635    653   +18     
- Misses        218    224    +6     
- Partials       96     99    +3

Impacted Files	Coverage Δ
src/Shared/Internal/HttpContextExtensions.cs	`54% <60%> (+4%)`	⬆️
src/NLog.Web/NLogRequestPostedBodyModule.cs	`69% <85%> (+9%)`	⬆️
...utRenderers/AspNetRequestDurationLayoutRenderer.cs	`56% <0%> (-9%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a234cfc...2c5c87a. Read the comment docs.

bakgerman · 2022-06-04T16:54:20Z

Should we also add 'application/soap+xml' to allow content type list, or will the charset entry already allow this? Many time the content type for SOAP is 'application/soap+xml; charset=utf-8'.

snakefoot · 2022-06-04T16:59:20Z

Should we also add 'application/soap+xml' to allow content type list, or will the charset entry already allow this? Many time the content type for SOAP is 'application/soap+xml; charset=utf-8'.

That should be covered by application/-prefix + xml-suffix. But yes any ContentType that contains charset will also pass the crude filter (expects charset means text that has been encoded).