-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tls Handshake Layout Render #802
Conversation
Thank you for the pull-request and the unit-tests. And you have been missing this layout-renderer while developing ASP.NET Core applications? |
Basically I had to prove the details of the TLS being used to the security team, I don't know why they think the application can affect the chosen handshake. But I have to prove the application innocent. |
I examined other interfaces available in the HttpContext FeatureCollection and did some more LayoutRenders, but I am not sure if they are good for NLog or not. I found the following, but these only work for ASP_NET_CORE3 case in NLog.Web: Http/2 request trailer |
Again. I'm an ignorant to ASP.NET Core applications, so my observations might not be true:
|
I see, we agree in our opinion. :) I am go on holiday today for a week but I will finish the unit tests and submit a pull request for the ones we think are useful for NLog. Regards, |
src/NLog.Web.AspNetCore/LayoutRenderers/TlsHandshakeProperty.cs
Outdated
Show resolved
Hide resolved
src/NLog.Web.AspNetCore/LayoutRenderers/AspNetTlsHandshakeLayoutRenderer.cs
Show resolved
Hide resolved
Implment review correections
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
=====================================
+ Coverage 68% 70% +1%
=====================================
Files 61 62 +1
Lines 1142 1146 +4
Branches 287 289 +2
=====================================
+ Hits 779 797 +18
+ Misses 239 225 -14
Partials 124 124
Continue to review full report at Codecov.
|
SonarCloud Quality Gate failed. |
Thank you again for another nice contribution. |
Add a single layout render, with an enum to specify which property to render, with unit tests.
Modelled upon ProcessInfoLayoutRenderer.
Hopefully better than 7 separate layout renderers.