Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended AspNetUserClaimLayoutRenderer to handle multi-values #975

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Extended AspNetUserClaimLayoutRenderer to handle multi-values #975

merged 5 commits into from
Aug 4, 2023

Conversation

bakgerman
Copy link
Contributor

@bakgerman bakgerman commented Aug 3, 2023 •
edited by snakefoot
Loading

I finally got to work on it today after 6 weeks. Please let me know if this is an accurate answer to the link in the issue.

Resolves #949

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 3, 2023
@pull-request-size pull-request-size bot added size/M and removed size/L labels Aug 3, 2023
Reduce the ifdef for NET46. Added a default return for GetAllClaims m…
ae62487 
…ethod to prevent a NullReferenceException in SerializePairs method.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@snakefoot snakefoot changed the title Work for Issue 949 to report all claim values in the claims principal. Extended AspNetUserClaimLayoutRenderer to handle multi-values Aug 4, 2023
snakefoot
snakefoot approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@snakefoot snakefoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and thank you for the unit-test.

@snakefoot snakefoot merged commit eb44f08 into NLog:master Aug 4, 2023
@snakefoot snakefoot mentioned this pull request Aug 4, 2023
Merged
@bakgerman bakgerman deleted the claim-multi-value-support branch August 4, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snakefoot snakefoot snakefoot approved these changes

Assignees
No one assigned
Labels
feature size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend AspNetUserClaimLayoutRenderer to handle multi-values
2 participants
@bakgerman @snakefoot