Minor improvements to InternalLogger output (#5012)

NLog · Aug 1, 2022 · 741d134 · 741d134
1 parent f332a63
commit 741d134
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/NLog/Conditions/Expressions/ConditionRelationalExpression.cs b/src/NLog/Conditions/Expressions/ConditionRelationalExpression.cs
@@ -230,7 +230,7 @@ private static bool TryPromoteType(ref object val, Type type1)
                 if (type1 == typeof(string))
                 {
                     val = Convert.ToString(val, CultureInfo.InvariantCulture);
-                    InternalLogger.Debug("Using string comparison");
+                    InternalLogger.Trace("Using string comparison");
                     return true;
                 }
             }

diff --git a/src/NLog/Conditions/Parsing/ConditionParser.cs b/src/NLog/Conditions/Parsing/ConditionParser.cs
@@ -138,7 +138,7 @@ private ConditionMethodExpression ParsePredicate(string functionName)
             }
             catch (Exception exception)
             {
-                InternalLogger.Warn(exception, "Cannot resolve function '{0}'", functionName);
+                InternalLogger.Warn(exception, "Failed to resolve condition method: '{0}'", functionName);
 
                 if (exception.MustBeRethrownImmediately())
                 {

diff --git a/src/NLog/Targets/FileTarget.cs b/src/NLog/Targets/FileTarget.cs
@@ -1242,7 +1242,7 @@ private void ArchiveFile(string fileName, string archiveFileName)
                 InternalLogger.Info("{0}: Archiving {1} to compressed {2}", this, fileName, archiveFileName);
                 if (File.Exists(archiveFileName))
                 {
-                    InternalLogger.Warn("{0}: Cannot created new compressed file, when file already exists: {1}", this, archiveFileName);
+                    InternalLogger.Warn("{0}: Failed archiving because compressed file already exists: {1}", this, archiveFileName);
                 }
                 else
                 {
@@ -1299,7 +1299,7 @@ private void ArchiveFileCompress(string fileName, string archiveFileName)
                         throw;
 
                     int sleepTimeMs = i * 50;
-                    InternalLogger.Warn("{0}: Attempt #{1} to compress {2} to {3} failed - {4} {5}. Sleeping for {6}ms", this, i, fileName, archiveFileName, ex.GetType(), ex.Message, sleepTimeMs);
+                    InternalLogger.Warn("{0}: Archiving Attempt #{1} to compress {2} to {3} failed - {4} {5}. Sleeping for {6}ms", this, i, fileName, archiveFileName, ex.GetType(), ex.Message, sleepTimeMs);
                     AsyncHelpers.WaitForDelay(TimeSpan.FromMilliseconds(sleepTimeMs));
                 }
             }

diff --git a/src/NLog/Targets/NetworkTarget.cs b/src/NLog/Targets/NetworkTarget.cs
@@ -359,19 +359,19 @@ private void WriteBytesToNewNetworkSender(string address, byte[] bytes, AsyncLog
                     switch (OnConnectionOverflow)
                     {
                         case NetworkTargetConnectionsOverflowAction.Discard:
-                            InternalLogger.Warn("{0}: Discarding message otherwise to many connections.", this);
+                            InternalLogger.Debug("{0}: Discarding message, because too many open connections.", this);
                             logEvent.Continuation(null);
                             return;
 
                         case NetworkTargetConnectionsOverflowAction.Grow:
                             MaxConnections = MaxConnections * 2;
-                            InternalLogger.Debug("{0}: Too may connections, but this is allowed", this);
+                            InternalLogger.Debug("{0}: Growing max connections limit, because many open connections.", this);
                             break;
 
                         case NetworkTargetConnectionsOverflowAction.Block:
                             while (_openNetworkSenders.Count >= MaxConnections)
                             {
-                                InternalLogger.Debug("{0}: Blocking networktarget otherwise too many connections.", this);
+                                InternalLogger.Debug("{0}: Blocking until ready, because too many open connections.", this);
                                 Monitor.Wait(_openNetworkSenders);
                                 InternalLogger.Trace("{0}: Entered critical section.", this);
                             }