Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebService target allow override of SoapAction through Headers #3100

Merged
merged 1 commit into from
Feb 3, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Feb 2, 2019

Follow up to #3081

And reduce string-allocations by only doing string.Concat once for ContentType and SoapAction (Unless overriding using Headers-Layout)

@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

Merging #3100 into dev will decrease coverage by <1%.
The diff coverage is 88%.

@@          Coverage Diff           @@
##             dev   #3100    +/-   ##
======================================
- Coverage     80%     80%   -<1%     
======================================
  Files        350     350            
  Lines      27592   27607    +15     
  Branches    3659    3661     +2     
======================================
- Hits       21994   21980    -14     
- Misses      4546    4576    +30     
+ Partials    1052    1051     -1

@304NotModified
Copy link
Member

👍

@snakefoot
Copy link
Contributor Author

snakefoot commented Mar 8, 2019

@304NotModified Updated Wiki: https://github.com/NLog/NLog/wiki/WebService-target (About possible override of default SoapAction for Soap11)

@304NotModified 304NotModified added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Mar 8, 2019
@snakefoot snakefoot deleted the WebServiceTargetSoap12action branch April 4, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) enhancement Improvement on existing feature needs documentation on wiki performance webservice-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants