LocalIpAddressLayoutRenderer - Higher priority when valid gateway #3754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
@jol5 Please check if the pre-release-build is able to resolved the expected https://ci.appveyor.com/project/nlog/nlog/builds/29958203/artifacts |
|
Polite bump @jol5 |
|
@304NotModified Don't think jol5 have English as first language and not in the mood for playing with local nuget-package stores, so it will be an uphill challenge to get any confirmation. You just have to take my word (or rather stackoverflows word) for that the solution will be working for VM-Ware-Nodes. |
|
Ok merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the real-ip will have a default-gateway:
https://stackoverflow.com/questions/8089685/c-sharp-finding-my-machines-local-ip-address-and-not-the-vms
While the VMware Network Adapter will have none or just 0.0.0.0