Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileTarget - New current file should write start header after archive of previous file #4106

Merged
merged 1 commit into from
Sep 2, 2020
Merged

FileTarget - New current file should write start header after archive of previous file #4106

merged 1 commit into from
Sep 2, 2020

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Sep 1, 2020 •
edited
Loading

Trying to resolve #4105. Bug was introduced with #1993

@snakefoot snakefoot added bug Bug report / Bug fix file-target file-archiving Issues with archiving with the file target labels Sep 1, 2020
@snakefoot snakefoot added this to the 4.7.5 milestone Sep 1, 2020
@snakefoot snakefoot mentioned this pull request Sep 1, 2020
Closed
@snakefoot snakefoot force-pushed the FileTargetNewFileWriteHeader branch 2 times, most recently from 7154169 to 23805b8 Compare September 2, 2020 05:36
304NotModified
304NotModified approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snakefoot snakefoot force-pushed the FileTargetNewFileWriteHeader branch from 23805b8 to 1f6ca51 Compare September 2, 2020 19:09
@snakefoot snakefoot force-pushed the FileTargetNewFileWriteHeader branch from 1f6ca51 to 6db449b Compare September 2, 2020 19:10
@snakefoot
Copy link
Contributor Author

Force-commit to remove code-smell, and improve InternalLogger.Debug-message.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

86.7% 86.7% Coverage
0.0% 0.0% Duplication

@304NotModified 304NotModified merged commit 56ff6f4 into NLog:master Sep 2, 2020
@304NotModified
Copy link
Member

@snakefoot please no force push next time. I cannot check what have been changed as the review state has been reset.

Ps: Nowadays I squash merge all pull requests if no explicit merge is needed after squash

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
@snakefoot snakefoot deleted the FileTargetNewFileWriteHeader branch July 30, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
bug Bug report / Bug fix file-archiving Issues with archiving with the file target file-target size/M
Projects
None yet
Milestone
4.7.5
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @304NotModified