-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement QED exact solution #135
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #135 +/- ##
===========================================
- Coverage 100.00% 98.64% -1.36%
===========================================
Files 78 81 +3
Lines 3725 4365 +640
===========================================
+ Hits 3725 4306 +581
- Misses 0 59 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@felixhekhorn @alecandido Question about names: in the nonsinglet evolution for the pure QCD we had the terms j00, j01 etc where the j functions are the integrals of as^k/beta_N^iLO(as). In that case k starts from 1. |
@niclaurenti |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
325 commits so far - I'm afraid I have to take some responsibility for that ...
Commits are not always a good measurement unit, in this case I believe the more relevant one is "days". Even though the two things are of course correlated (and the conversion in this case approaches 1). Since this PR is never-ending, and we are being unable to merge, and even to review, we should reconsider a minimal goal and way to test.
If the present status passes all these checks, I'd rather merge even if it is not perfect, and incrementally improve and refactor, otherwise we'll keep some manpower stuck on this development, and pay over and over the cost of reviewing an extensive bunch of code... |
@niclaurenti if you confirm @alecandido's list- let's merge! |
Yes they are not affected. But let me run some pure QCD benchmarks in order to be 100% sure |
math.isnan(couplings.alphaem.scale)
then deactivate thealphaem_running
flag