Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement QED exact solution #135

Merged
merged 329 commits into from
Mar 9, 2023
Merged

Implement QED exact solution #135

merged 329 commits into from
Mar 9, 2023

Conversation

niclaurenti
Copy link
Contributor

@niclaurenti niclaurenti commented Jul 5, 2022

  • if math.isnan(couplings.alphaem.scale) then deactivate the $\alpha$ running
    • to be traded for the current alphaem_running flag

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #135 (55e80fe) into develop (3eda004) will decrease coverage by 1.35%.
The diff coverage is 93.00%.

❗ Current head 55e80fe differs from pull request most recent head bd11a38. Consider uploading reports for the commit bd11a38 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #135      +/-   ##
===========================================
- Coverage   100.00%   98.64%   -1.36%     
===========================================
  Files           78       81       +3     
  Lines         3725     4365     +640     
===========================================
+ Hits          3725     4306     +581     
- Misses           0       59      +59     
Flag Coverage Δ
isobench ?
unittests 98.64% <93.00%> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/eko/scale_variations/exponentiated.py 100.00% <ø> (ø)
src/eko/couplings.py 84.08% <58.92%> (-15.92%) ⬇️
src/eko/evolution_operator/__init__.py 95.11% <90.16%> (-4.89%) ⬇️
src/eko/anomalous_dimensions/__init__.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/aem1.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/aem2.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as1.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as1aem1.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as2.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as3.py 100.00% <100.00%> (ø)
... and 13 more

@felixhekhorn felixhekhorn added enhancement New feature or request physics new physics features labels Jul 5, 2022
@niclaurenti
Copy link
Contributor Author

@felixhekhorn @alecandido Question about names: in the nonsinglet evolution for the pure QCD we had the terms j00, j01 etc where the j functions are the integrals of as^k/beta_N^iLO(as). In that case k starts from 1.
However in the QED case we have also the case k=0. Should we rename the already implemented j_ki by shifting by 1 the first index (i.e. j00 -> j10, j01 -> j11, etc) such that k=0 is the integral of 1/beta(as)? Or maybe we should find another name?

@felixhekhorn felixhekhorn changed the title Feature/qed-solution Implement QED exact solution Jul 13, 2022
@felixhekhorn felixhekhorn mentioned this pull request Jul 18, 2022
7 tasks
tests/eko/test_ad.py Outdated Show resolved Hide resolved
tests/eko/test_ad.py Outdated Show resolved Hide resolved
@felixhekhorn
Copy link
Contributor

felixhekhorn commented Jul 22, 2022

@niclaurenti since your touching solutions here and #137 was doing as well, maybe make sure by merging that your fine with the changes there ...
EDIT: actually I'm wrong: #137 only updated ads - so you should be fine ...

@niclaurenti niclaurenti requested review from alecandido and felixhekhorn and removed request for alecandido March 3, 2023 16:39
Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

325 commits so far - I'm afraid I have to take some responsibility for that ...

doc/source/theory/pQCD.rst Show resolved Hide resolved
src/eko/evolution_operator/__init__.py Show resolved Hide resolved
@alecandido
Copy link
Member

325 commits so far - I'm afraid I have to take some responsibility for that ...

Commits are not always a good measurement unit, in this case I believe the more relevant one is "days". Even though the two things are of course correlated (and the conversion in this case approaches 1).

Since this PR is never-ending, and we are being unable to merge, and even to review, we should reconsider a minimal goal and way to test.
Something like:

  1. it should change existing tests as little as possible (new ones are more than welcome), and of course pass them
  2. it should pass a few relevant benchmarks against APFEL
  3. existing configurations should be unaffected; to be tested in practice by rerunning some EKOs with this branch and main, and test for a compatible (if possible bit-per-bit equal) result

If the present status passes all these checks, I'd rather merge even if it is not perfect, and incrementally improve and refactor, otherwise we'll keep some manpower stuck on this development, and pay over and over the cost of reviewing an extensive bunch of code...

@felixhekhorn
Copy link
Contributor

  1. it should change existing tests as little as possible (new ones are more than welcome), and of course pass them

  2. it should pass a few relevant benchmarks against APFEL

  3. existing configurations should be unaffected; to be tested in practice by rerunning some EKOs with this branch and main, and test for a compatible (if possible bit-per-bit equal) result

@niclaurenti if you confirm @alecandido's list- let's merge!

@niclaurenti
Copy link
Contributor Author

  1. it should change existing tests as little as possible (new ones are more than welcome), and of course pass them
  2. it should pass a few relevant benchmarks against APFEL
  3. existing configurations should be unaffected; to be tested in practice by rerunning some EKOs with this branch and main, and test for a compatible (if possible bit-per-bit equal) result

@niclaurenti if you confirm @alecandido's list- let's merge!

Yes they are not affected. But let me run some pure QCD benchmarks in order to be 100% sure

@niclaurenti niclaurenti merged commit e772437 into master Mar 9, 2023
@niclaurenti niclaurenti deleted the feature/qed-solution branch March 9, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Benchmark (or infrastructure) related enhancement New feature or request physics new physics features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants