-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor runner #159
Refactor runner #159
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #159 +/- ##
===========================================
- Coverage 99.95% 99.95% -0.01%
===========================================
Files 97 97
Lines 4519 4496 -23
===========================================
- Hits 4517 4494 -23
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
In particular, in In any case, this runner will be completely reworked in the context of #138 |
This should be ok now, we just need to fix the tests. Before doing that, can you confirm that this is what we want? @felixhekhorn @alecandido |
Yep, I confirm :) |
I am merging, thanks for this :) |
We want to massively simplify
runnner.py
:get_output
we want to avoid the rotations: if needed they should be done afterwards.__init__
we just need to skip the last part in whichtargetpids
,inputpids
,targetgrid
andinputgrid
are collected.@felixhekhorn @alecandido