Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize runner #160

Closed
wants to merge 1 commit into from
Closed

Reorganize runner #160

wants to merge 1 commit into from

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Nov 8, 2022

At the moment, runner was more or less the core of EKO, despite us calling it "more a library than an application".

We should collect all stuffs related to runner, and improve it, also in consideration of the new runner coming from #138

  • write runcards objects, currently sketched in runner.runcards Runcards Dataclasses #153
  • the new runcard objects should be used, where now the dictionary runcard is passed
    • only the required information has to be passed, and nothing more (absolutely not the full runcard)
    • thus use the default object constructors, dropping the from_dict (incidentally, this will close Exterminate from_dict #114)
  • move run_dglap() out of top level, and scope in runner (if it is more a library, then there is no special reason the only object define top level should be the runner)
    • we can still export to the top scope for compatibility
  • inherit also runcards object from output.struct.DictLike, since they are the objects mostly going to and from dictionary (because of serialization)
    • as a consequence, we should also move DictLike out of the output subpackage (as a rule of thumb, since subpackages are made to collect and isolate, they should not talk to each other, but only with the upper scope)

Closes #153

@alecandido alecandido changed the base branch from master to develop November 8, 2022 11:01
This was linked to issues Nov 8, 2022
@alecandido alecandido requested review from andreab1997 and felixhekhorn and removed request for andreab1997 November 8, 2022 11:11
@felixhekhorn felixhekhorn added enhancement New feature or request refactor Refactor code labels Nov 8, 2022
@felixhekhorn
Copy link
Contributor

Can we please drop ade4abf and d2eb93c from here and put them in a separate PR - they're changing everything which makes this PR unreadable (and they got nothing to do with this - in fact, the tasks in here are already highly non-trivial on their own)

@alecandido
Copy link
Member Author

alecandido commented Nov 8, 2022

Can we please drop ade4abf and d2eb93c from here and put them in a separate PR - they're changing everything which makes this PR unreadable (and they got nothing to do with this - in fact, the tasks in here are already highly non-trivial on their own)

Indeed, I noticed and cherry-picked to develop

EDIT: cherry-picked and rebased, such that this is back to the single commit it was

@alecandido alecandido force-pushed the feature/reorganize-runner branch from d2eb93c to 30bf898 Compare November 8, 2022 11:54
@alecandido alecandido mentioned this pull request Nov 8, 2022
@alecandido
Copy link
Member Author

Deprecated in favor of #172

@alecandido alecandido closed this Dec 8, 2022
@alecandido alecandido mentioned this pull request Dec 8, 2022
20 tasks
@felixhekhorn felixhekhorn deleted the feature/reorganize-runner branch January 5, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runcards Dataclasses Exterminate from_dict
3 participants