-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize CLI #171
Reorganize CLI #171
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## output_metadata #171 +/- ##
===================================================
- Coverage 99.93% 99.43% -0.51%
===================================================
Files 96 100 +4
Lines 4515 4586 +71
===================================================
+ Hits 4512 4560 +48
- Misses 3 26 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Docs can be improved, there is no coverage for the new commands. However, not my priority at the moment, so I will stop working on this here for a while, and use for my next PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two v0.8.5 example ekos we for sure want to support given that most of our "real-life" ekos are of this version - both fail:
- the yaml due to the problem given below
- the other with
$ poetry run eko convert obf24af_t8e1305.tar
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/home/felix/.cache/pypoetry/virtualenvs/eko-KkPVjVhh-py3.10/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
return self.main(*args, **kwargs)
File "/home/felix/.cache/pypoetry/virtualenvs/eko-KkPVjVhh-py3.10/lib/python3.10/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/home/felix/.cache/pypoetry/virtualenvs/eko-KkPVjVhh-py3.10/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/felix/.cache/pypoetry/virtualenvs/eko-KkPVjVhh-py3.10/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/felix/.cache/pypoetry/virtualenvs/eko-KkPVjVhh-py3.10/lib/python3.10/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/home/felix/Physik/N3PDF/EKO/eko/src/ekobox/cli/convert.py", line 27, in subcommand
operator = legacy.load_tar(old)
File "/home/felix/Physik/N3PDF/EKO/eko/src/eko/output/legacy.py", line 278, in load_tar
metadata = tocard(yaml.safe_load(fd))
File "/home/felix/Physik/N3PDF/EKO/eko/src/eko/output/legacy.py", line 84, in tocard
del card["pids"]
KeyError: 'pids'
Also benchmarks are broken:
EDIT: sorry is already a problem in the base branch ... I'll raise there |
The EKO CLI was already initialized, but completely forgotten and unused.
I will add some basic commands to generate EKOs, useful to test further developments.