-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polarized Matching conditions #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor style comments
Remember to resolve the annotations here if you have addressed them (unless you're not sure whether it has been done as requested) |
src/ekore/operator_matrix_elements/polarized/space_like/__init__.py
Outdated
Show resolved
Hide resolved
src/ekore/operator_matrix_elements/polarized/space_like/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
Co-authored-by: Giacomo Magni <39065935+giacomomagni@users.noreply.github.com>
Maybe you're missing some tests (both fixing the current ones and adding new ones). However, whenever you're ready, please remove draft mode :) |
Sorry for spoiling this PR with unpolarized docs business - but since I needed to look at them for comparison, I started to improve them a bit ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have any real life PDF comparison, do we?
No unfortunately. |
Update: By the way the statement at page 7 just below chapter 4 title in 1908.03779 should definitely proof we have to use the M scheme expressions. |
@felixhekhorn I feel now we can merge this and eventually open and issue about the matching scheme to keep track of it. |
Agreed |
Implementation of polarised matching conditions.