Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polarized Matching conditions #221

Merged
merged 27 commits into from
May 17, 2023
Merged

Polarized Matching conditions #221

merged 27 commits into from
May 17, 2023

Conversation

giacomomagni
Copy link
Collaborator

Implementation of polarised matching conditions.

@giacomomagni giacomomagni marked this pull request as draft March 6, 2023 12:02
@giacomomagni giacomomagni added physics new physics features enhancement New feature or request labels Mar 6, 2023
Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor style comments

@felixhekhorn
Copy link
Contributor

Remember to resolve the annotations here if you have addressed them (unless you're not sure whether it has been done as requested)

adrianneschauss and others added 3 commits March 15, 2023 09:56
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
Co-authored-by: Giacomo Magni <39065935+giacomomagni@users.noreply.github.com>
@alecandido
Copy link
Member

Maybe you're missing some tests (both fixing the current ones and adding new ones).

However, whenever you're ready, please remove draft mode :)

@giacomomagni giacomomagni marked this pull request as ready for review March 31, 2023 15:02
@felixhekhorn
Copy link
Contributor

Sorry for spoiling this PR with unpolarized docs business - but since I needed to look at them for comparison, I started to improve them a bit ...

Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any real life PDF comparison, do we?

@giacomomagni
Copy link
Collaborator Author

We don't have any real life PDF comparison, do we?

No unfortunately.
At DIS I asked Kay Schonwald if they can provide us some implementation to benchmark with,
this way we can be sure to have fixed the typos correctly.
That's mainly why this PR is still open.

@giacomomagni
Copy link
Collaborator Author

Update:
I wrote again to kay Schonwald if there will be no reply, we might consider to merge and hope everything is in good order.

By the way the statement at page 7 just below chapter 4 title in 1908.03779 should definitely proof we have to use the M scheme expressions.
I also checked that our polarised splitting function $P_{qg}^{(1)}$ is indeed in that scheme a NLO.

@giacomomagni
Copy link
Collaborator Author

@felixhekhorn I feel now we can merge this and eventually open and issue about the matching scheme to keep track of it.

@felixhekhorn
Copy link
Contributor

@felixhekhorn I feel now we can merge this and eventually open and issue about the matching scheme to keep track of it.

Agreed

@giacomomagni giacomomagni merged commit 9321633 into master May 17, 2023
@giacomomagni giacomomagni deleted the polarized_matching branch May 17, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request physics new physics features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants