Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #413

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Oct 14, 2024

updates:
- [github.com/pre-commit/pre-commit: v4.0.0 → v4.0.1](pre-commit/pre-commit@v4.0.0...v4.0.1)
@felixhekhorn felixhekhorn merged commit ed3d22b into master Oct 15, 2024
6 of 7 checks passed
@felixhekhorn felixhekhorn deleted the pre-commit-ci-update-config branch October 15, 2024 07:25
@alecandido
Copy link
Member

@felixhekhorn, in case you're interested in, the pre-commit CI is broken exactly because of the previous pre-commit 4.0.0 release.
This broke the docformatter, and they already implemented a fix:
PyCQA/docformatter#287
but we are waiting for the release
PyCQA/docformatter#293

Unfortunately, the pre-commit CI is pretty simple, and you can not specify which version of pre-commit to run. So, a breaking change (as expected from major) may break hooks, and propagate to the CI. Luckily, it's not happening that often (and maybe sooner or later they may allow for a pre-commit version to be specified...).

@felixhekhorn
Copy link
Contributor

yeah, I found out already yesterday (because it broke already in one of the PRs we merged yesterday) ... I 👍-ed the issue already in hope for a quick release ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants