-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new output format #77
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #77 +/- ##
===========================================
+ Coverage 99.25% 99.27% +0.01%
===========================================
Files 29 29
Lines 2149 2200 +51
===========================================
+ Hits 2133 2184 +51
Misses 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tests for coverage
dump eko version into metadata (add to get_raw())
this definitely needs to be addressed before merging (esp. the first ;-) )
For sure, but I wanted to get your thoughts on current implementation actually :) |
Looks reasonable! |
The last |
@felixhekhorn I provided the test for the new output (a bit stupid but working) d620a68. Nevertheless, looks like there is not any longer a 100% coverage, because of In any case, here I'm ready to merge. |
Closes #76
get_raw()
) 7d48679