Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: tutorial for running fit with scale variation theory covmat #1110

Merged
merged 14 commits into from
Mar 15, 2021

Conversation

RosalynLP
Copy link
Contributor

This was one of the tutorials in #656 to be written.

In writing this I noticed that the docs for the theorycovariance module were a little out of date so I have updated them. I also need to fix the theorycovariance examples folder runcards (in the wake of the data specification update) but I will do that in a separate PR.

I've added an example runcard for a fit with theory covariance matrix to the runcards folder.

@RosalynLP RosalynLP requested review from voisey and tgiani and removed request for voisey and tgiani February 25, 2021 11:41
@RosalynLP RosalynLP requested review from tgiani and voisey and removed request for voisey February 25, 2021 19:24
@RosalynLP
Copy link
Contributor Author

@voisey if you have some time could you review this one please? I think you most know the module

@voisey
Copy link
Contributor

voisey commented Mar 9, 2021

Hey @RosalynLP, sure, will do! It's on my to do list

@RosalynLP
Copy link
Contributor Author

Hey @RosalynLP, sure, will do! It's on my to do list

Thanks, sorry there are just so many PRs I am not sure what the situation is with all of them.

@voisey
Copy link
Contributor

voisey commented Mar 9, 2021

No no, it's good that you reminded me 😛

doc/sphinx/source/tutorials/thcov_tutorial.rst Outdated Show resolved Hide resolved

This section details how to include scale variation covariance matrices (covmats)
in a PDF fit. At the present time this can only be done at NLO, for which the
central theory is theory 163.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please link to the page that explains what a theory is?

doc/sphinx/source/tutorials/thcov_tutorial.rst Outdated Show resolved Hide resolved
doc/sphinx/source/tutorials/thcov_tutorial.rst Outdated Show resolved Hide resolved
doc/sphinx/source/tutorials/thcov_tutorial.rst Outdated Show resolved Hide resolved
RosalynLP and others added 4 commits March 9, 2021 18:04
Co-authored-by: Cameron Voisey <32741139+voisey@users.noreply.github.com>
Co-authored-by: Cameron Voisey <32741139+voisey@users.noreply.github.com>
@RosalynLP
Copy link
Contributor Author

RosalynLP commented Mar 11, 2021

@voisey I made the changes you suggested and have just merged master to solve some conflicts. Could you have one last look and see what you think (Note: the link to the example runcard will not work until we merge this because it doesn't appear in the github repo yet), and then maybe we can merge

@RosalynLP
Copy link
Contributor Author

@voisey I made the suggested changes. Thanks for spotting them!

@voisey voisey merged commit aa06460 into master Mar 15, 2021
@voisey voisey deleted the thcovtutorial branch March 15, 2021 18:08
@voisey
Copy link
Contributor

voisey commented Mar 15, 2021

Thanks @RosalynLP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants