-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring the documentation #1122
Conversation
@RosalynLP, these docs are looking niiiiiiiiiiiiiiiice |
We're getting there! |
I think this is ready now @Zaharid @wilsonmr @siranipour @tgiani would be great if some of you could have a look and see what you think, any more structural suggestions etc. Caveat is that we intend to have an overview of the code after "getting started" to explain very loosely how everything links together - see @wilsonmr was assigned this in #656. Also fixing the search bar broke Travis... |
@RosalynLP @voisey Could I trouble you for a high level summary of what changed? Looking at the diff is not particularly easy... |
@RosalynLP the error travis gives is
|
Ok thank you! |
What has changed
Seee #1121 for a tick box list |
As a comment |
Here is as good a place as any. Do you mean rather than describing it as a new model blah blah blah we just say it is the fitting code |
I'd just remove a lot of that indeed. |
@Zaharid lmk what you think of the last commit |
I'm not entirely happy with the n3fit section... it explains the methodology of n3fit but is not very helpful for someone trying to understand the code. And the readme here https://github.com/NNPDF/nnpdf/tree/master/n3fit/src/n3fit is out of date. I think we could do with some sections on code structure, explaining how it all fits together and what the different bits do, and update the readme. @scarlehoff what are your thoughts on this? I am happy to do it but it would be good to have your help to look over what I've written. But I think this is part of a broader issue we need to address of explaining the general code structure. We have decided to do a brief overview (assigned to @wilsonmr) but maybe we need something more for n3fit and validphys especially. |
Sure, I'd be happy to help. |
OK amazing, although that is definitely work for a different PR than this. |
Addresses #1121