Add tests for sum rules #1507
Merged
Add tests for sum rules #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaharid
reviewed
Jan 28, 2022
| ret = pd.concat([known_sumrules, central_val], axis=1) | ||
| # The unknown sum rules need to be treated a bit because | ||
| # 1) They don't contain min or max | ||
| # 2) They are of type object? |
There was a problem hiding this comment.
This is so that the central value and error are displayed with a reasonable number of decimals in all cases. See
I guess one could use unknown_sum_rules action instead.
There was a problem hiding this comment.
I see. But the other problem stays so not sure if it changes much (and the others are floats)
Zaharid
reviewed
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sum rules are important enough to be tested explicitly.