Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize the effect of cmake/C++ across the code #1864

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Minimize the effect of cmake/C++ across the code #1864

merged 6 commits into from
Jan 19, 2024

Conversation

scarlehoff
Copy link
Member

@scarlehoff scarlehoff commented Nov 24, 2023 •
edited
Loading

Depends on #1861

This PR:

  • Removes C++ code that is no longer used anywhere (i.e., nnpdfcpp)
  • Isolates the pieces that we want to keep for the time being (i.e., evolven3fit)
  • Removes conda C++ dependencies that are no longer needed

@scarlehoff scarlehoff marked this pull request as draft November 24, 2023 17:39
@scarlehoff scarlehoff added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Nov 24, 2023
@github-actions GitHub Actions
Copy link

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

@scarlehoff scarlehoff added devtools Build, automation and workflow and removed run-fit-bot Starts fit bot from a PR. labels Nov 27, 2023
@scarlehoff scarlehoff mentioned this pull request Nov 27, 2023
Merged
@scarlehoff scarlehoff marked this pull request as ready for review November 28, 2023 15:48
@scarlehoff scarlehoff changed the title Minimize the effect of cmake across the code Minimize the effect of cmake/C++ across the code Nov 28, 2023
@scarlehoff
Copy link
Member Author

I think this is the most I can clean the repository from cmake and C++ code without breaking evolven3fit and buildmaster.

@scarlehoff scarlehoff force-pushed the minimize_cmake branch 2 times, most recently from 7f24ab7 to 79641d6 Compare December 4, 2023 15:43
@scarlehoff scarlehoff force-pushed the change_installation_method branch 2 times, most recently from 0361733 to 3b7d9a1 Compare December 13, 2023 15:43
@scarlehoff scarlehoff force-pushed the minimize_cmake branch 2 times, most recently from 5f1deb6 to ff793b8 Compare December 17, 2023 11:01
@scarlehoff scarlehoff force-pushed the change_installation_method branch 2 times, most recently from 77f3dec to 52d3a6f Compare December 21, 2023 11:14
@scarlehoff scarlehoff force-pushed the change_installation_method branch from 52d3a6f to a0f850e Compare January 17, 2024 08:25
Base automatically changed from change_installation_method to develop_20240119 January 19, 2024 12:05
@scarlehoff scarlehoff merged commit aac4ec9 into develop_20240119 Jan 19, 2024
6 checks passed
@scarlehoff scarlehoff deleted the minimize_cmake branch January 19, 2024 12:09
scarlehoff added a commit that referenced this pull request Jan 24, 2024
@scarlehoff
Merge pull request #1914 from NNPDF/develop_merge_20240119, includes: #…
af3306a 
…1871, #1864, #1861 and #1888

WIP Merging
@scarlehoff scarlehoff mentioned this pull request Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyStegeman RoyStegeman Awaiting requested review from RoyStegeman

Assignees
No one assigned
Labels
destroyingc++ devtools Build, automation and workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@scarlehoff