-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate regression updates #1944
Conversation
cd2e36f
to
004fdf1
Compare
faa9442
to
7c73713
Compare
Thanks! I think git bot commits cannot trigger again the checks. Let's see whether having the previous check is enough for the branch rules to consider the branch as ok. Also, I like that we will basically have a |
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
10c7d1b
to
5adb063
Compare
They just changed again, so there is still some source of randomness somewhere. Not really an issue though I think, changes are very small. |
Yes, sure. I'm just surprised that integrability changed while the The integrability asks the NN for a bunch of points and sums them together, while the (in any case I agree, it doesn't really matter. I just found it curious). |
To be sure everythings ok I checked that if I run it locally, those do get changed. What about the fit-bot? |
Actually that's not true, looking a bit more carefully, only the timings changed now. |
What do you mean? |
Earlier I thought the regression data was changed twice, so there was some randomness still, but I think I wasn't looking carefully enough, it was only the timings that changed the second time. Or if you mean on the fit bot:
|
Ah, no, don't update the fitbot like this. |
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
…egression-updates.
c6e74ec
to
8d3ecc0
Compare
Ok, then this is done I think? I just rebased to master. |
Thanks! This is nice! |
Aim
Be able to add a red-regressions label and have the regressions be recomputed in the CI and automatically committed.
Status
It seems to be working for the extra regression tests, the result of the workflow applied to this PR as a test is the commit d142744
I don't know about the fitbot, if we want to automate that too I guess it would be a different workflow but using the same label. And what would need to be updated exactly? The developing_weights are a starting point, so I assume those stay the same. Would you want to update the reference fit that it compares against?
Also, I expected the bot's push to trigger the other tests again, but it seems this doesn't happen. I don't know if that's necessary or not.