Passes variant info to TupleComp for DataSetInput #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also removes parenthesis from @lru_cache, see: https://bugs.python.org/issue36772
scarlehoff
approved these changes
May 18, 2024
There was a problem hiding this comment.
Thinking more about this, given that variant is more general than sys if this creates a problem somewhere that would mean there was a bug.
So I'd be willing to merge this asap.
This also paves the way to this issue I just opened #2086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes variant info to TupleComp for DataSetInput
Also removes parenthesis from @lru_cache, see: https://bugs.python.org/issue36772