Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinematic labels #2093

Closed
wants to merge 35 commits into from
Closed

kinematic labels #2093

wants to merge 35 commits into from

Conversation

tgiani
Copy link
Contributor

@tgiani tgiani commented May 28, 2024

addressing #2025

@tgiani
Copy link
Contributor Author

tgiani commented May 30, 2024

regarding ATLAS_WJ_JET_8TEV: is there a reason because of which k2 is set to a placeholder rather than m_W^2?
The original buildmaster implementation is here https://github.com/NNPDF/buildmaster/blob/master/filters/ATLAS_WJET_8TEV.cc

min: null
mid: 0.0
max: null
k2:
MWZ:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the names from

(so m_W2 instead of MW2...or... in this case, m_V and we will need to add a new variable for that)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what s the procedure to add a new variable? In the case above we need m_V, for ATLAS_PH_13TEV we need the transverese ewnergy square ET2 and I guess there will be other cases. Is it enought to add these new variables to the _Vars class?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. And then for the processes for which you want to add it, include it in the "accepted variables".

(if the process still doesn't exist you can either create it or leave it for later, it should not matter)

@scarlehoff
Copy link
Member

I took the values from the commondata that were available, so I guess at some point it became a placeholder.

If you want to change it feel free. If not... we've lived with that for a while so ¯_(ツ)_/¯

@tgiani
Copy link
Contributor Author

tgiani commented May 31, 2024

just to keep track of the new variables:

  • ATLAS_DY_13TEV : m_V
  • ATLAS_PH_13TEV : ET2
  • ATLAS_WPWM_13TEV : m_W
  • ATLAS_Z0_7TEV_49FB: m_ll, m_ll2
  • ATLAS_Z0_7TEV_LOWMASS: m_ll2
  • ATLAS_Z0_8TEV_HIGHMASS: m_ll2
  • ATLAS_Z0_8TEV_LOWMASS: m_ll2
  • ATLAS_Z0_13TEV: m_Z
  • ATLAS_Z0J_8TEV: m_ll2
  • DYE605 : m_ll2

@scarlehoff scarlehoff closed this Dec 4, 2024
@scarlehoff scarlehoff deleted the kin_labels branch December 4, 2024 07:25
@scarlehoff
Copy link
Member

Closed since most of them have now been done in the specific PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants