Add uncertainty variants for select datasets #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarlehoff
reviewed
Oct 28, 2024
nnpdf_data/nnpdf_data/commondata/ATLAS_2JET_13TEV_DIF/filter.py
Outdated
Show resolved
Hide resolved
|
hi @t7phy for the datasets for which the uncertainty is well separated you can create two files
And then the data_uncertainties entry can be a list and they will be concatenated. That way the information doesn't need to be repeatead in the file with and without uncertainties (and the size of these files will be reduced considerably) |
scarlehoff
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Thanks for this. Just a small comment.
However, wouldn't it be better to add this during the filter or is there a reason why this cannot be done in this way?
So, while running the filter, instead of creating the full file and afterwards separating the lumi; can't it be separated from the beginning?
nnpdf_data/nnpdf_data/commondata/ATLAS_1JET_13TEV_DIF/uncertainties_wo-lumi.yaml
Outdated
Show resolved
Hide resolved
scarlehoff
force-pushed
the
ts261024
branch
2 times, most recently
from
b3c138c to
c9c76e4
Compare
add lumi-less variant atlas 1j add lumi-less variant atlas 2j add lumi-less variant cms 1j automate add lumi-less variant h1 1j 290 add lumi-less variant h1 2jet 290 add lumi-less variant h1 jets 351 isort add a uncert skipping util function add lumi and lumiless for zeus 1j 38p6 pb-1 add lumi and lumiless for zeus 1j 82pb-1 add lumi and lumiless for zeus 2j 374pb-1 lumiless atlas 13tev ttb lj lumiless atlas 13tev ttb hadr make h1 datasets use utils func impl sugg zeus 1j 38p6 update utils impl sugg zeus 1j 82 impl sugg zeus 1j 82, fix metadata impl sugg dis+j impl sugg atlas 1j 13t impl sugg atlas 2j 13t impl sugg cms 1j 13t variant->variants
scarlehoff
reviewed
Nov 12, 2024
scarlehoff
added
the
Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds uncertainty variants for some gluon-PDF sensitive processes where luminosity uncert is excluded, for reproducibility of pheno paper