Exterminate k1,k2,k3 from Fixed target data #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, thank you! The error is weird, and I cannot reproduce it... I wonder whether it is related to the other error we see ramdomly... |
|
@giacomomagni can we try to rebase both this and the parent PR on master to see whether the problems dissapear? |
|
okay sure |
scarlehoff
force-pushed
the
clean_legacy_fixed_target_dis_kinematics
branch
from
abb8df6 to
a72f7e3
Compare
scarlehoff
force-pushed
the
clean_legacy_fixed_target_dis_kinematics
branch
from
a72f7e3 to
d06b9d1
Compare
Merged
scarlehoff
force-pushed
the
clean_legacy_fixed_target_dis_kinematics
branch
from
d06b9d1 to
57b5304
Compare
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to remove the
k1,k2,k3variables from the Fixed target legacy dataset.I split the commit here, in case there are further changes needed in the plotting options.