Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] n3fit unit testing #590

Merged
merged 19 commits into from
Nov 7, 2019
Merged

[WIP] n3fit unit testing #590

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b870129
added unit tests for the n3fit backend operations
scarlehoff Oct 10, 2019
ef1838f
add tests for the loss functions
scarlehoff Oct 10, 2019
dd0b3e2
add tests for the DIS and DY layers
scarlehoff Oct 11, 2019
0f17379
added n3fit to the test script
scarlehoff Oct 11, 2019
4769cfe
address review comments: add docstrings
scarlehoff Oct 16, 2019
0536a54
added a first attempt to a full-fit comparison
scarlehoff Oct 17, 2019
db34647
make my change of mind a bit less evident
scarlehoff Oct 17, 2019
5f40fa3
change the quickcard.yml to use the test theory
scarlehoff Oct 31, 2019
5babfb0
use tf2 thread-seed handling
scarlehoff Oct 31, 2019
d8f30b0
regression fit test
scarlehoff Oct 31, 2019
2de9067
now it should also work if you are in another folder...
scarlehoff Oct 31, 2019
b60f738
and now it might also work for non-development environ
scarlehoff Oct 31, 2019
7986c62
sigh
scarlehoff Nov 1, 2019
e92cac2
forgot to add runcard to the right folder
scarlehoff Nov 4, 2019
b5385c8
set KMP_DUPLICATE_LIB_OK flag in fit test
scarlehoff Nov 4, 2019
9b4a7c9
add comment to KMP flag
scarlehoff Nov 6, 2019
cebabbd
use subprocess how it is suppossed to be used
scarlehoff Nov 7, 2019
209fb2b
add docstring
scarlehoff Nov 7, 2019
a4a4624
try noshell
scarlehoff Nov 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions n3fit/src/n3fit/tests/test_fit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ def test_performfit():
tmp_path = pathlib.Path(tmp_name)
# cp runcard to tmp folder
shutil.copy(QUICKPATH, tmp_path)
os.chdir(tmp_path)
# run the fit
os.environ['KMP_DUPLICATE_LIB_OK'] = 'TRUE'
new_environment = {"KMP_DUPLICATE_LIB_OK": "TRUE", **os.environ}
# The flag KMP_DUPLICATE_LIB_OK is necessary to avoid some errors
# related to the linking of OMP in travis when running under MacOS
sp.run(f"{EXE} {QUICKCARD} {REPLICA}", shell=True)
proc = sp.run(f"{EXE} {QUICKCARD} {REPLICA}", shell=True, env=new_environment, cwd = tmp_path)
assert proc.returncode == 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add check=True to subprocess.run.

# read up the .fitinfo files
full_path = tmp_path / f"{QUICKNAME}/nnfit/replica_{REPLICA}/{QUICKNAME}.fitinfo"
new_fitinfo = load_data(full_path)
Expand Down