Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #84.
It's a tiny PR, and we can even quickly merge.
I ran existing tests, and slightly extended (sorry for the diff, but someone forgot to run
black
on unit tests).I even tested it manually, and it's smoothly working.
Speaking of tests: maybe it might be a good chance to extend the IO related ones a bit (
write_lz4
is not tested, norread
,write
andwrite_lz4
for FkTables... actually almost nothing is tested of Fk).In any case: the interface is a thin wrapper, so an extensive test suite is not that required, and we can even postpone to a more consistent tests rework.