Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify multiple convolution functions with CLI #293

Merged
merged 29 commits into from
Jun 27, 2024
Merged

Conversation

cschwan
Copy link
Contributor

@cschwan cschwan commented Jun 10, 2024

This will close #174.

TODO:

  • migrate subcommand analyze; done in commit cfcf027
  • migrate subcommand convolve; done in commit 1436618
  • migrate subcommand plot; done in commit 1d4af96 and ddbf227
  • migrate subcommand pull; done in commit a29639b
  • migrate subcommand uncert; done in commit 5f8e576

@cschwan
Copy link
Contributor Author

cschwan commented Jun 15, 2024

While converting some of the code to use the new ConvFun structs I stumbled upon a new question we need answer: how do we calculate PDF/FF uncertainties if two PDFs are given, for instance?

@cschwan
Copy link
Contributor Author

cschwan commented Jun 15, 2024

While converting some of the code to use the new ConvFun structs I stumbled upon a new question we need answer: how do we calculate PDF/FF uncertainties if two PDFs are given, for instance?

To answer my question, it is instructive to think about the following situation: one PDF, one FF. In that case we now have two uncertainties: a PDF uncertainty and a FF uncertainty. In general we thus have an uncertainty associated to each one of the different convolution functions. We can calculate the uncertainty by varying the members of this set, while keeping the members of the other sets fixed (to the central member, for instance).

@felixhekhorn
Copy link
Contributor

While converting some of the code to use the new ConvFun structs I stumbled upon a new question we need answer: how do we calculate PDF/FF uncertainties if two PDFs are given, for instance?

To answer my question, it is instructive to think about the following situation: one PDF, one FF. In that case we now have two uncertainties: a PDF uncertainty and a FF uncertainty. In general we thus have an uncertainty associated to each one of the different convolution functions. We can calculate the uncertainty by varying the members of this set, while keeping the members of the other sets fixed (to the central member, for instance).

I think for the moment this is what needs to be done - but I just wanted to point out that this might (or might not) be more complicated in principle: this assumes that the two ($N$) convolutions are uncorrelated (which for now they are). However, if one day we decide to fit PDF and FF simultaneously this assumption would fail and you would need to vary them consistently.

@cschwan
Copy link
Contributor Author

cschwan commented Jun 17, 2024

[..] I just wanted to point out that this might (or might not) be more complicated in principle: this assumes that the two (N) convolutions are uncorrelated (which for now they are). However, if one day we decide to fit PDF and FF simultaneously this assumption would fail and you would need to vary them consistently.

Ah, that's a good point, thanks for pointing that out. In that case we will very likely need support from a convolution function library ('partons') that will tell us how exactly the uncertainty has to be calculated.

@cschwan cschwan merged commit 93db089 into master Jun 27, 2024
9 checks passed
@cschwan cschwan deleted the ts050624 branch June 27, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for different initial-state hadrons in the CLI
3 participants