Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pineappl dependency to fix LO bug #125

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

scarlehoff
Copy link
Member

Fixes #121

(I haven't updated poetry.lock & stuff, but want the fktables I'm doing to "point" to a published commit)

@scarlehoff scarlehoff changed the title Bump pineappl dependeny to fix LO bug Bump pineappl dependency to fix LO bug Oct 9, 2023
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very quick comment. It is fine to bump.

pyproject.toml Outdated Show resolved Hide resolved
@alecandido
Copy link
Member

Ah, wait: you should run

poetry lock

and commit the resulting lock file.

(this is the reason why tests are failing, sorry to have noticed only after the approval)

@felixhekhorn felixhekhorn merged commit baecb98 into main Oct 10, 2023
4 checks passed
@felixhekhorn felixhekhorn deleted the bump_pineappl_0.6.2 branch October 10, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when creating a Leading Order table
3 participants