Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move regression test #127

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Move regression test #127

merged 4 commits into from
Oct 11, 2023

Conversation

felixhekhorn
Copy link
Contributor

  • Major change is to move the regression test of @scarlehoff to benchmarks (since it is definitely no unit test and takes quite some time)
  • I will however add a few other minor changes

@felixhekhorn felixhekhorn added the refactor Refactor code label Oct 10, 2023
@felixhekhorn felixhekhorn marked this pull request as ready for review October 10, 2023 13:57
@felixhekhorn
Copy link
Contributor Author

  • @scarlehoff we may want to consider at some point to move the regression test on theories_slim instead of theories, right?
  • @andreab1997 please double check the change in merge_grids (and by the way: the name nec_orders is not the best name ever 🙈 )

@scarlehoff
Copy link
Member

Indeed, it should now look at theories_slim

andreab1997
andreab1997 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@andreab1997 andreab1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look everywhere but in particular to merge_grids and it looks good @felixhekhorn

@andreab1997
Copy link
Contributor

  • @andreab1997 please double check the change in merge_grids (and by the way: the name nec_orders is not the best name ever 🙈 )

I agree it is not the best but I am not good with names. If you have any other suggestions I am happy to apply it :)

@felixhekhorn
Copy link
Contributor Author

Indeed, it should now look at theories_slim

I leave this to a future PR

@felixhekhorn felixhekhorn merged commit 0b4631f into main Oct 11, 2023
4 checks passed
@felixhekhorn felixhekhorn deleted the move-regression-test branch October 11, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreab1997 andreab1997 andreab1997 approved these changes

@alecandido alecandido alecandido approved these changes

@scarlehoff scarlehoff Awaiting requested review from scarlehoff

Assignees
No one assigned
Labels
refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixhekhorn @scarlehoff @andreab1997 @alecandido