Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polarized opcards #128

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Polarized opcards #128

merged 5 commits into from
Oct 18, 2023

Conversation

giacomomagni
Copy link
Contributor

@giacomomagni giacomomagni commented Oct 16, 2023

This PR is to allow the computation of polarized Ekos.

As is it now the polarisation is triggered by the name of the DIS observable.
As this does not work for Hadronic datasets, we should refine it.

Copy link
Member

@Radonirinaunimi Radonirinaunimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as long as we stick to the idea that any term that multiplies the polarised structure functions are accounted as $k$-factors (hence one single observable) $-$ which will always be the case unless we do a simultaneous fit. In addition to this, no polarised observable are given as a linear combination of (polarised) structure functions. So, this LGTM!

src/pineko/evolve.py Outdated Show resolved Hide resolved
giacomomagni and others added 2 commits October 16, 2023 15:43
Co-authored-by: Tanjona Rabemananjara <rrabeman@nikhef.nl>
@giacomomagni
Copy link
Contributor Author

giacomomagni commented Oct 16, 2023

This looks good as long as we stick to the idea that any term that multiplies the polarised structure functions are accounted as k-factors (hence one single observable) − which will always be the case unless we do a simultaneous fit.

This should not be a problem even in that case as the dataset will contain 2 Fk-tables so 2 Operator cards will be needed.

In addition to this, no polarised observable are given as a linear combination of (polarised) structure functions. So, this LGTM!

Any new polarised DIS observable not starting with g (or viceversa) could be a problem.

For hadronic datasets we can add and elif once such grids will be available.

@Radonirinaunimi
Copy link
Member

This should not be a problem even in that case as the dataset will contain a 2 FKtables so 2 Operator cards will be needed.

Right! That makes sense.

Any new polarised DIS observable not starting with g (or viceversa) could be a problem.

Indeed! However, for now and for the far future I don't foresee this being the case.

For hadronic datasets we can add and elif once such grids will be available.

Agree, we should address this once these hadronic pineappl grids are available.

@giacomomagni giacomomagni changed the title Polarized opcards DIS polarized opcards Oct 16, 2023
src/pineko/evolve.py Outdated Show resolved Hide resolved
@giacomomagni giacomomagni changed the title DIS polarized opcards Polarized opcards Oct 17, 2023
Copy link
Member

@Radonirinaunimi Radonirinaunimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this could be merged soon (followed by a release) that'd be great 🙃

Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the minimal change I was expecting 🙃

@felixhekhorn felixhekhorn merged commit bcdbaf9 into main Oct 18, 2023
4 checks passed
@felixhekhorn felixhekhorn deleted the polarized_opcards branch October 18, 2023 10:03
@felixhekhorn
Copy link
Contributor

@Radonirinaunimi feel free to make immediately an release (else #99 will for sure trigger a release, but maybe you want to disentangle 😇 )

@Radonirinaunimi
Copy link
Member

@Radonirinaunimi feel free to make immediately an release (else #99 will for sure trigger a release, but maybe you want to disentangle 😇 )

Thanks @felixhekhorn ! We surely want a release in which this is first disentangle from #99.

@giacomomagni giacomomagni linked an issue Oct 19, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for polarized
4 participants