Use just the nnpdf-data package #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you have any specific objections to this, otherwise we could even merge and release. |
Co-authored-by: Roy Stegeman <roystegeman@live.nl>
giacomomagni
approved these changes
Nov 26, 2024
felixhekhorn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the moment that @felixhekhorn had been waiting for so long!
At long last, a package containing the data and the theories without any of the tensorflow / keras / vp bullshit! https://pypi.org/project/nnpdf-data/
It also doesn't install the
rawdataof course (which will be removed from the main repository anyway). fwiw the dependencies can be trimmed a bit more. e.g., I don't think the pin on ruamel is really needed, and pandas is only necessary when loading the data (pineko uses only the metadata). But I'll leave that for later.Currently I've uploaded the package by hand to pypi since until the commondata project is not finished I cannot realistically have this PR NNPDF/nnpdf#2225 in master since it would create too many conflicts.