Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pineko to check if the grid contains SV #24
Allow pineko to check if the grid contains SV #24
Changes from 17 commits
ff57aab
c13474d
f7f3e06
02ee40d
4fad303
7713ff0
b1598f6
c7987f8
9fdd291
8322198
f2eecce
b4dc401
8c14399
7c3147a
0316a2f
cd68db0
bd2dbdd
5fcc283
703c316
5d194df
5a3df49
26ee37e
fbeae62
3f9d6fe
b406490
c053a86
72c7889
1928fcf
460af45
8e4ba78
48ec795
381426e
6cec81c
b88a051
7c30efe
261a2c7
776af28
a3bc157
975b8fe
3010f8c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixhekhorn didn't we have another variable, e.g. in yadism. In order to compute scale variations, even when we are not given a specific value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we have there "activateFact" (or similar name) in order to decide whether to compute the SV grids - however for
pineko
this is not sufficient since we need to collapse on the actual value - or what were you thinking?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, so it is just the first part of the comment to be referred to the code below.
Maybe I'd just move it: first
# check if sv are requested
then# in case of sv, check they are available in the grid
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean just the comments right? because the code is already doing that: first it checks if the theory is asking for scale-variations and then it checks whether they are available in the gird.