address deprecation of ruamel.yaml functions #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this compatible with nnpdf? Because we are using yaml from reportengine. fwiw, I tried removing the pin here NNPDF/nnpdf#2225 and it failed, so there's at least one function for which it doesn't work |
|
Yes compat.py will be broken with this since the syntax for ruamel.yaml has changed so we'd have to pin the reportengine version while we do these same changes on the nnpdf side To test I could do a branch to update ruamel.yaml in nnpdf that installs reportengine from this branch before we merge either one? |
|
Yes please, and then we merge both branches at the same time. This should be fine since we are getting reportengine from github anyway (and branches in all PRs will need to be rebased but I'm perfectly fine with that :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.18.0 of
ruamel.yaml, the old PyYAML functions have been removed. This PR updates to the new functionality that is there since version 0.15.0.