Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yadism theory cards. #293

Closed
giacomomagni opened this issue Jul 5, 2024 · 0 comments · Fixed by #294
Closed

Update Yadism theory cards. #293

giacomomagni opened this issue Jul 5, 2024 · 0 comments · Fixed by #294
Labels
bug Something isn't working refactor Refactor code

Comments

@giacomomagni
Copy link
Collaborator

giacomomagni commented Jul 5, 2024

The parsing of the new nnpdf theory cards is not compliant with yadism anymore.

In particular :

  1. Here we need to allow for floats:

    "CKM": CKM2Matrix.from_str(
    theory["CKM"]
    ), # TODO remove default in PDG2020 Eq. 12.33

  2. The kyes RenScaleVar, FactScaleVar are no longer supported, so we should consider to drop them here.
    I suggest to include scale variations as default and eventually allow the possibility of skipping them.
    In particular as grids do not depends on XIR and XIF it's more convenient to have them also for the central theories.

  3. This line

    if "PTODIS" not in theory:

has to be modified to:

if "PTODIS" not in theory or theory["PTODIS"] is None:
@giacomomagni giacomomagni added bug Something isn't working refactor Refactor code labels Jul 5, 2024
@giacomomagni giacomomagni linked a pull request Jul 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor Refactor code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant