Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different hotfixes #294

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Different hotfixes #294

merged 6 commits into from
Jul 12, 2024

Conversation

giacomomagni
Copy link
Collaborator

This PR includes 3 different hotfixes to make yadism running again.

  • Fix new pineappl convention.
  • Add empty IC coefficient functions for polarized structure functions (needed since we have dropped IC).
  • Update theory cards compatibility layer, according to the new NNPPDF runcards.

The only change that is not strictly necessary is setting RenScaleVar,FactScaleVar to True if the key is not present.
I find this change quite handy to speed up the computation of scale varied theories, but if you don't like it
I'm happy to drop it.

@giacomomagni giacomomagni added the bug Something isn't working label Jul 5, 2024
@giacomomagni giacomomagni self-assigned this Jul 5, 2024
@giacomomagni giacomomagni linked an issue Jul 5, 2024 that may be closed by this pull request
Update Yadism theory cards. #293
Closed
Radonirinaunimi
Radonirinaunimi approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@Radonirinaunimi Radonirinaunimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't have a preference re the _ScaleVar part as I am not myself extensively generating SVed theories.

@giacomomagni giacomomagni merged commit 700479e into master Jul 12, 2024
5 checks passed
@giacomomagni giacomomagni deleted the compatibility_and_hotfixes branch July 12, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radonirinaunimi Radonirinaunimi Radonirinaunimi approved these changes

@felixhekhorn felixhekhorn felixhekhorn approved these changes

@RoyStegeman RoyStegeman Awaiting requested review from RoyStegeman

Assignees

@giacomomagni giacomomagni

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Yadism theory cards.
3 participants
@giacomomagni @felixhekhorn @Radonirinaunimi