Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eko as git submodule. #13

Merged
merged 29 commits into from
Feb 3, 2020
Merged

Added eko as git submodule. #13

merged 29 commits into from
Feb 3, 2020

Conversation

alecandido
Copy link
Member

The actual branch in which adding the eko dependency.

@alecandido alecandido self-assigned this Jan 28, 2020
@alecandido alecandido requested a review from scarlehoff January 28, 2020 14:37
@scarlehoff
Copy link
Member

Why is a specific commit needed?

@alecandido
Copy link
Member Author

@scarlehoff I need a specific commit because some functions currently used in dis are already deprecated in dis.

In order to do things by sequential steps I'm trying to checkout the last commit in which they were still present in eko, rather than fixing dis logic in order to fix continuous integration.

@alecandido
Copy link
Member Author

Still to be solved:

  • problem with version in meta.yaml (not able to compile jinja template even if git describe --tags available)
  • the problem: conda build fails with a stack trace barely readable dd3a988

@alecandido
Copy link
Member Author

One (fake) solution:

  • rule out conda-recipe and use conda manually to install apfel and lhapdf only
  • is working as long as we don't have to deploy
  • if we have to deploy somewhere we are writing a full python package, and if there will be no final dependence on lhapdf we can deploy directly on PyPI, fully avoiding conda

This is not the solution that I want to achieve right now, but I liked to write it here because is still solution, and I'm quite annoyed by fixing stuffs inside conda.

@alecandido alecandido requested a review from scarrazza January 28, 2020 17:15
@alecandido
Copy link
Member Author

@scarrazza when you will be again available I would like to listen also to your opinion, please :)

@alecandido
Copy link
Member Author

Ok, I think I'm ready:

  • I removed any conda-build trace
  • now the workflow is perfectly working with eko
    If the reviewers agree we can merge this into the other branch ('docker-to-conda-action') and than in the master (or the other way: the other into the master and this into the master too).

Thank you @scarlehoff to help me trying to fix it with conda-build, and thank you very much @scarrazza to make me free of that.

@alecandido alecandido changed the base branch from docker-to-conda-action to master February 3, 2020 19:15
@alecandido alecandido merged commit 3fbe2ef into master Feb 3, 2020
@alecandido alecandido deleted the eko-dependency branch March 18, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants