Add an observable relevant for FPF studies #161
Conversation
src/yadism/esf/exs.py
Outdated
| @@ -5,6 +5,7 @@ | |||
| from .esf import ESFInfo | |||
| from .result import ESFResult, EXSResult | |||
|
|
|||
| INV_GEV_TO_PB = 3.8937966e8 # pb | |||
There was a problem hiding this comment.
@tanjona, the conversion between pb and cm2 is almost trivial, and in any case I would store in a separate constant.
As you can see, we have now two constants, with a mantissa that is the same up to 1e2 and you obtain essentially next line...)
There was a problem hiding this comment.
This does make sense! I have removed the explicit definition of the constant but rather kept the variable name in the code just to make it explicit which conversion is being done XD.
|
Benchmarks are failing because they should not run, I lost track where they have been introduced (there is a long discussion going on since 2 years with @felixhekhorn, I hope I will fix this, sooner or later...). Apart the comment above, the rest looks good to me. When you are ready (i.e. replied to the comment), just ask again for review and I will approve :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 70.36% 70.39% +0.02%
==========================================
Files 90 90
Lines 4262 4266 +4
==========================================
+ Hits 2999 3003 +4
Misses 1263 1263
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I was indeed wondering about the failing benchmarks but knew that this surely had nothing to do with the modifications. |
|
Thanks! I will merge this then now. |
| @@ -67,6 +67,10 @@ def xs_coeffs(kind, y, x=None, Q2=None, params=None): | |||
| ym = 0 | |||
| yp = 1.0 | |||
| yL = y**2 / (2 * (y**2 / 2 + (1 - y) - (mn * x * y) ** 2 / Q2)) | |||
| elif kind == "XSFPFCC": | |||
| INV_GEV_TO_PB = GEV_CM2_CONV / 100.0 # Pb | |||
There was a problem hiding this comment.
I guess the comment should be rather pb (note the small p - as in pico) (just to not confuse with lead 🙃 )
There was a problem hiding this comment.
To really nitpick Pb in this context would mean "PetaBarn", instead of "picoBarn", according to SI.
There was a problem hiding this comment.
This is definitely a fair point! In addition, in what we are doing we also need the observable name added to the observable_name.py. Let me restore this branch and add these changes here.
For the FPF studies we need a definition of the double differential cross section that is not available yet. This PR just adds such a definition.