Drop inspector and related features #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Despite I declared this to be ready to merge, remember that is pointing to #239. Thus, we should wait for that to be merged first (or rebase on The two of them should be pretty independent (the only file touched by both is |
alecandido
force-pushed
the
ditch-inspector
branch
from
0f286a5 to
551b3af
Compare
felixhekhorn
approved these changes
Nov 6, 2023
|
Can we merge this? either with #239 or without ... cc @Radonirinaunimi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only module preserved in the
inputsubpackage is thecompatibilityone (since I believe is heavily used).Originally, I wanted to introduce in this PR even the new runcard format, as I did in EKO (and rename the
inputsubpackage toio, to mirror the same structure in both packages).However, dropping the inspector has almost no consequence, in practice, since it is barely used (and almost not even tested, since some of them were skipped).
But adding the new runcards could be a breaking change, and we'll definitely need some more time for them, with potentially limited benefits in the short term.
I might author a draft PR about the new runcards in the next days, but for sure I'd like to keep it separate from this one (that is ready to merge, once reviewed).