Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump yadism dependencies #269

Merged
merged 3 commits into from
Mar 22, 2024
Merged

bump yadism dependencies #269

merged 3 commits into from
Mar 22, 2024

Conversation

scarlehoff
Copy link
Member

Closes #268

@felixhekhorn
Copy link
Contributor

sorry made a small mess (committed to master instead of here)

@felixhekhorn felixhekhorn added the dependencies Pull requests that update a dependency file label Mar 22, 2024
@scarlehoff
Copy link
Member Author

sorry made a small mess (committed to master instead of here)

I didn't remove 3.8 from the tests but maybe it should be (I see the regression still includes 3.7 even)

@felixhekhorn
Copy link
Contributor

sorry made a small mess (committed to master instead of here)

I didn't remove 3.8 from the tests but maybe it should be (I see the regression still includes 3.7 even)

I was thinking the same, but since we still support 3.8 I guess there is no harm, no?

regressions are completely out of date and not running nor working

@scarlehoff
Copy link
Member Author

Actually, I did remove 3.8 from pyproject, how come the test is successful?

@scarlehoff
Copy link
Member Author

Ok, I can answer that

The currently activated Python version 3.8.18 is not supported by the project (>=3.9,<3.13).
Trying to find and use a compatible version. 
Using python3.10 (3.10.12)

poetry takes over and changes the test xD

@felixhekhorn
Copy link
Contributor

Actually, I did remove 3.8 from pyproject, how come the test is successful?

Indeed - I was looking to master, again ...

@scarlehoff
Copy link
Member Author

do you want me to add the pydoc missing to ignore ?

@felixhekhorn
Copy link
Contributor

do you want me to add the pydoc missing to ignore ?

yes, yes we're ignoring it for a while now #208 #263

@felixhekhorn felixhekhorn merged commit bde1c76 into master Mar 22, 2024
4 of 5 checks passed
@felixhekhorn felixhekhorn deleted the bump_deps branch March 22, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pineappl dependency
2 participants