Removed unused zooplankton upward swimming #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yichengt900
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
@charliestock , Code changes look good, and it passed both 1D and NWA12-RT tests. Approve. I will cleanup the diag_table later.
|
@charliestock , Code changes look good, and it passed both 1D and NWA12-RT tests. Approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes some preliminary work to implement upward zooplankton swimming to avoid detrainment. This was ultimately not used in any production codes and will be replaced with a more complete representation of zooplankton movement that Jessica is working on with Mathieu Poupon and Laure Resplandy.
This should not change answers. No changes to the diagnostic table are required, but we should probably delete the following lines (which were already commented out):
"generic_cobalt_z","chl2sfcchl", "chl2sfcchl", "ocean_cobalt_tracers_month_z","all","mean","none",2
"generic_cobalt_z","jupswim_n_Smz", "jupswim_n_Smz","ocean_cobalt_tracers_month_z","all","mean","none",2
"generic_cobalt_z","jupswim_n_Mdz", "jupswim_n_Mdz","ocean_cobalt_tracers_month_z","all","mean","none",2
"generic_cobalt_z","jupswim_n_Lgz", "jupswim_n_Lgz","ocean_cobalt_tracers_month_z","all","mean","none",2
"generic_cobalt_z","vmove_Smz", "vmove_Smz", "ocean_cobalt_tracers_month_z","all","mean","none",2
"generic_cobalt_z","vmove_Mdz", "vmove_Mdz", "ocean_cobalt_tracers_month_z","all","mean","none",2
"generic_cobalt_z","vmove_Lgz", "vmove_Lgz", "ocean_cobalt_tracers_month_z","all","mean","none",2