-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added comments to the phytoplankton mortality section #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great! I just added a tiny comment for clarity, but aside from that I think it looks great!
Hello @yichengt900 @gabyneg @jessluo - I added a commit that addressed the comment typo that Gaby caught and added comments to the rest of the plankton foodweb section. Take a quick look when/if you have a chance and perhaps we can pull this in on Monday? thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charliestock , Thanks for adding those comments. Overall they look good to me except a few typos. I can fix them on my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! caught a few more typos.
do j = jsc, jec ; do i = isc, iec !{ | ||
! | ||
! assume that individually sinking phytoplankton collect in nepholoid layer | ||
! and are available for resuspension if they are exposed to mixing | ||
do n = 1,NUM_PHYTO | ||
if (cobalt%zt(i,j,nk).le.(2.0*hblt_depth(i,j))) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about this -- if you use just the hblt_depth
here instead of twice the depth of active mixing, does this result in too much burial and removal of phytoplankton N/Si/Fe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jessica - right now burial is turned off since we were very concerned with too much burial in regional applications with enhanced resolution of nearshore areas. We also found, however, that assuming that slowly sinking cells were immediately buried and remineralized in the nearshore regions rather than being available for re-entrainment was suppressing nearshore chlorophyll.
I think these will be a good topic for additional sensitivity, with the Mississippi hypoxic zone likely providing a good test case.
Thanks @jessluo and @gabyneg! @charliestock, I fixed all the typos except for two great questions from @jessluo. I will merge this PR once they are resolved |
The second question is more of a science question, so I think only addressing the question on line 3622 would be fine for this PR. |
Thanks for the questions and comment typo fixes (and sorry there were so many). Agree that the second question is a good science one that can be addressed through sensitivities and subsequent pull requests. @yichengt900, if you could switch the other to nitrogen, that would be great. |
Thanks again @charliestock, @jessluo and @gabyneg for all your contributions to this PR. @charliestock I addressed all of the comments and this PR is ready to merge. |
This pull request improves the commenting in the phytoplankton loss section. There were no changes to the actual code and it should not change answers. I have tagged @jessluo and @gabyneg for a quick look to ensure the commenting is accessible and informative.