Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep ISH tests from failing CI if data unreachable #289

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Keep ISH tests from failing CI if data unreachable #289

merged 4 commits into from
Oct 7, 2024

Conversation

zmoon
Copy link
Collaborator

@zmoon zmoon commented Oct 7, 2024

Let's get that ✔ back.

xref: noaa-oar-arl/monetio#202

@zmoon zmoon requested a review from rschwant October 7, 2024 21:38
@zmoon zmoon changed the title Keep ISH tests from failing CI Keep ISH tests from failing CI if data unreachable Oct 7, 2024
rschwant
rschwant approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@rschwant rschwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, yay will be good to be passing our tests again!

@zmoon zmoon merged commit 61a618c into NOAA-CSL:develop Oct 7, 2024
4 checks passed
@zmoon zmoon deleted the skip-ish branch October 7, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschwant rschwant rschwant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmoon @rschwant